Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BCH New adddress gen error #249

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

BCH New adddress gen error #249

wants to merge 1 commit into from
+8 −15

Conversation

cnohall
Copy link
Contributor

@cnohall cnohall commented Jun 1, 2021

This PR is related to issue #247.

BTC and BCH both show the same error and duplicate code has been removed and refactored.

One small #247 (comment) is that I would like to remove the Note to webmaster: part of the gaplimit error message. Let me know what you think.

DarrenWestwood
DarrenWestwood approved these changes Jul 15, 2021
View reviewed changes
Copy link
Collaborator

@DarrenWestwood DarrenWestwood left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are clean and working correctly. Let's replace Note to webmaster: with Note to webmaster - as the message is still relevant to the site admin and should remain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarrenWestwood DarrenWestwood DarrenWestwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cnohall @DarrenWestwood